Fix 'issue 11: too many values to unpack' #12
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 33048 of easylist (2015-05-09 18:54 UTC) has:
There are two seperate
$
's in that rule which causes abp_import.py to error out with:Traceback (most recent call last):
File "./abp_import.py", line 101, in
main()
File "./abp_import.py", line 98, in main
print translate_all(easylist, infile)
File "./abp_import.py", line 71, in translate_all
str += translate(line)
File "./abp_import.py", line 54, in translate
pat, opts = line.split("$",2)
ValueError: too many values to unpack
Makefile:18: recipe for target 'privoxy/easylist.action' failed
make: *** [privoxy/easylist.action] Error 1
This fix splits on the last occurence of
$
. It also makes sure that the maxpossible values returned by line.split() is two, so that the first occurrence
of $ won't get split.
Fixes #11